go: change LogOptions.Ephemeral from bool to *bool (#827)

Previously, LogOptions.Ephemeral was a plain bool, so callers could not
distinguish between 'not set' (zero value false) and an explicit false.
This meant the SDK could never send ephemeral=false on the wire, always
deferring to the server default.

Change the field to *bool so nil means 'not set' (omitted from the
JSON-RPC payload) and a non-nil value is forwarded as-is. This is
consistent with how the other SDKs (Node, Python, .NET) handle the
field.

Author: SteveSandersonMS

go/internal/e2e/session_test.go

@@ -981,7 +981,7 @@ func TestSessionLog(t *testing.T) {
 	})
 
 	t.Run("should log ephemeral message", func(t *testing.T) {
-		if err := session.Log(t.Context(), "Ephemeral message", &copilot.LogOptions{Ephemeral: true}); err != nil {
+		if err := session.Log(t.Context(), "Ephemeral message", &copilot.LogOptions{Ephemeral: copilot.Bool(true)}); err != nil {
 			t.Fatalf("Log failed: %v", err)
 		}
 

go/session.go

@@ -711,8 +711,9 @@ type LogOptions struct {
 	// [rpc.Warning], and [rpc.Error].
 	Level rpc.Level
 	// Ephemeral marks the message as transient so it is not persisted
-	// to the session event log on disk.
-	Ephemeral bool
+	// to the session event log on disk. When nil the server decides the
+	// default; set to a non-nil value to explicitly control persistence.
+	Ephemeral *bool
 }
 
 // Log sends a log message to the session timeline.
@@ -730,16 +731,16 @@ type LogOptions struct {
 //	session.Log(ctx, "Rate limit approaching", &copilot.LogOptions{Level: rpc.Warning})
 //
 //	// Ephemeral message (not persisted)
-//	session.Log(ctx, "Working...", &copilot.LogOptions{Ephemeral: true})
+//	session.Log(ctx, "Working...", &copilot.LogOptions{Ephemeral: copilot.Bool(true)})
 func (s *Session) Log(ctx context.Context, message string, opts *LogOptions) error {
 	params := &rpc.SessionLogParams{Message: message}
 
 	if opts != nil {
 		if opts.Level != "" {
 			params.Level = &opts.Level
 		}
-		if opts.Ephemeral {
-			params.Ephemeral = &opts.Ephemeral
+		if opts.Ephemeral != nil {
+			params.Ephemeral = opts.Ephemeral
 		}
 	}
 

go/types.go

@@ -64,7 +64,10 @@ type ClientOptions struct {
 }
 
 // Bool returns a pointer to the given bool value.
-// Use for setting AutoStart: AutoStart: Bool(false)
+// Use for option fields such as AutoStart, AutoRestart, or LogOptions.Ephemeral:
+//
+//	AutoStart: Bool(false)
+//	Ephemeral: Bool(true)
 func Bool(v bool) *bool {
 	return &v
 }