fix(submission): show blocked view when instructor toggles student view#8269
Open
enkr1 wants to merge 1 commit intoCoursemology:masterfrom
Open
fix(submission): show blocked view when instructor toggles student view#8269enkr1 wants to merge 1 commit intoCoursemology:masterfrom
enkr1 wants to merge 1 commit intoCoursemology:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5488
Problem
When "block student viewing after submission" is enabled, students see a lock screen after finalizing. But when an instructor toggles "Student View" on the same submission, they still see the full submission — the blocked view is not shown.
Root Cause
The block check only runs on the backend (
submission_view_blocked?), which checkscourse_user.student?. Instructors are never students, so the block is never triggered — even in student view mode.Fix
Backend (
edit.json.jbuilder):blockStudentViewingAfterSubmittedin the assessment JSON so the frontend knows the setting is enabledFrontend (
SubmissionEditIndex):graderView: false), check if the submission would be blocked (not attempting, not published, setting enabled)<BlockedSubmission />in place of the submission contentNot changed