Skip to content

Fix bump configuration#449

Merged
rob93c merged 5 commits intomainfrom
fix-bump-configuration
Dec 23, 2025
Merged

Fix bump configuration#449
rob93c merged 5 commits intomainfrom
fix-bump-configuration

Conversation

@rob93c
Copy link
Member

@rob93c rob93c commented Dec 23, 2025

Summary by CodeRabbit

  • Chores
    • Removed a legacy build utility script.
    • Updated dependency management to exclude ffmpeg-related packages from automatic updates.
    • Adjusted Docker build context and build directive annotations to reflect current build patterns.
    • Minor CI workflow comment expansion (no runtime effect).

✏️ Tip: You can customize this high-level summary in your review settings.

@rob93c rob93c self-assigned this Dec 23, 2025
@rob93c rob93c added dependencies Pull requests that update a dependency file docker This marks issues revolving around Docker cicd The change affects CI/CD flows labels Dec 23, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 23, 2025

📝 Walkthrough

Walkthrough

Removes the hashupdate utility, deletes its .dockerignore exclusion, updates Renovate rules to skip ffmpeg packages, and broadens an ffmpeg version-bump pattern in a Dockerfile comment.

Changes

Cohort / File(s) Summary
Docker build context & metadata
\.dockerignore, Dockerfile
Removed hashupdate from .dockerignore; updated Dockerfile bump directive comment to broaden ffmpeg version-matching pattern (comment-only change).
CI / automation config
.github/renovate.json, .github/workflows/unit-test.yml
Added negated match (! *ffmpeg*) to Renovate package names to exclude ffmpeg updates; expanded a commented pattern in the unit-test workflow (no runtime effect).
Removed utility script
hashupdate
Deleted Bash script that fetched a URL, computed SHA256, and injected the hash into a target file.

Sequence Diagram(s)

(omitted — changes do not introduce a new multi-component control flow requiring visualization)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • MartelliEnrico

Poem

🐰
I hopped through lines of build and script,
Said goodbye to hashes once tightly gripped.
Comments widened their versioned view,
Renovate skips ffmpeg, it's true —
A tidy patch, a garden nipped.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix bump configuration' directly relates to the primary changes: updating the bump directive comment in the Dockerfile and adjusting Renovate configuration to exclude ffmpeg packages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9461536 and bb88b5d.

📒 Files selected for processing (1)
  • .github/renovate.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/renovate.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Execute unit tests (macos-latest)
  • GitHub Check: Execute unit tests (windows-latest)
  • GitHub Check: Execute unit tests (ubuntu-latest)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b497046 and 9461536.

📒 Files selected for processing (5)
  • .dockerignore
  • .github/renovate.json
  • .github/workflows/unit-test.yml
  • Dockerfile
  • hashupdate
💤 Files with no reviewable changes (2)
  • .dockerignore
  • hashupdate
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: rob93c
Repo: Stickerifier/Stickerify PR: 392
File: hashupdate:6-6
Timestamp: 2025-08-14T11:26:25.138Z
Learning: The hashupdate script in the Stickerify project only runs in Linux environments (Docker containers/CI), so macOS compatibility considerations like using `shasum` instead of `sha256sum` are not needed.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Execute unit tests (windows-latest)
  • GitHub Check: Execute unit tests (macos-latest)
  • GitHub Check: Execute unit tests (ubuntu-latest)
  • GitHub Check: Build and upload Docker image
🔇 Additional comments (2)
.github/workflows/unit-test.yml (1)

29-29: Bump directive pattern broadened for ffmpeg version management.

The comment expands the bump pattern to docker:mwader/static-ffmpeg|/\d+\./|*, which appears to broaden version filtering. This change is coordinated with disabling ffmpeg updates in Renovate configuration, suggesting a transition to the bump tool for managing ffmpeg versions.

Since this is a comment and doesn't affect runtime behaviour, the change is safe.

Dockerfile (1)

5-5: Bump directive pattern broadened for ffmpeg base image.

The comment expands the bump pattern to docker:mwader/static-ffmpeg|/\d+\./|*, consistent with the workflow file change. This broadens version filtering and aligns with disabling ffmpeg updates in Renovate, transitioning version management to the bump tool.

Since this is a comment and doesn't affect the Docker build, the change is safe.

Copy link
Contributor

@MartelliEnrico MartelliEnrico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rob93c rob93c merged commit 994194c into main Dec 23, 2025
6 checks passed
@rob93c rob93c deleted the fix-bump-configuration branch December 23, 2025 18:35
@coderabbitai coderabbitai bot mentioned this pull request Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cicd The change affects CI/CD flows dependencies Pull requests that update a dependency file docker This marks issues revolving around Docker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants