Skip to content

chore: add build step in release workflow#10312

Merged
manudeli merged 3 commits intomainfrom
ci/build-before-publish
Mar 21, 2026
Merged

chore: add build step in release workflow#10312
manudeli merged 3 commits intomainfrom
ci/build-before-publish

Conversation

@manudeli
Copy link
Collaborator

@manudeli manudeli commented Mar 21, 2026

#10303
In this commit, the test:ci step was removed, and release workflow runs the build. Previously, the build directory were being generated as part of that step, but now that it's skipped, the dist/build output isn’t created before publish.

As a result, the published package is missing the build folder.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 21, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cc59b82e-2e40-47fb-9979-d7a57c29b044

📥 Commits

Reviewing files that changed from the base of the PR and between 0ddf442 and b03aaed.

📒 Files selected for processing (2)
  • .changeset/pretty-canyons-fetch.md
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

A patch release changeset is added to coordinate updates across multiple TanStack Query packages, and a new build step is introduced to the release workflow to compile all packages before publishing.

Changes

Cohort / File(s) Summary
Release Coordination
.changeset/pretty-canyons-fetch.md
New changeset metadata file marking a patch release across Angular, Preact, React, Solid, Svelte, Vue, and multiple storage/persistence packages to resolve an excluded build directory issue.
Workflow Automation
.github/workflows/release.yml
Adds a "Run Build" step that executes pnpm run build:all in the release workflow, positioned after tool setup and before subsequent release operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop-hop, a build before we release,
Coordinates across packages, none cease,
From Vue to React, Solid and more,
The changeset opens the distribution door,
One step compiled, all platforms set free!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/build-before-publish

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Mar 21, 2026

View your CI Pipeline Execution ↗ for commit b03aaed

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 19s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-21 15:48:58 UTC

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2026

🚀 Changeset Version Preview

24 package(s) bumped directly, 0 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/angular-query-experimental 5.94.4 → 5.94.5 Changeset
@tanstack/angular-query-persist-client 5.94.4 → 5.94.5 Changeset
@tanstack/eslint-plugin-query 5.94.4 → 5.94.5 Changeset
@tanstack/preact-query 5.94.4 → 5.94.5 Changeset
@tanstack/preact-query-devtools 5.94.4 → 5.94.5 Changeset
@tanstack/preact-query-persist-client 5.94.4 → 5.94.5 Changeset
@tanstack/query-async-storage-persister 5.94.4 → 5.94.5 Changeset
@tanstack/query-broadcast-client-experimental 5.94.4 → 5.94.5 Changeset
@tanstack/query-core 5.94.4 → 5.94.5 Changeset
@tanstack/query-devtools 5.94.4 → 5.94.5 Changeset
@tanstack/query-persist-client-core 5.94.4 → 5.94.5 Changeset
@tanstack/query-sync-storage-persister 5.94.4 → 5.94.5 Changeset
@tanstack/react-query 5.94.4 → 5.94.5 Changeset
@tanstack/react-query-devtools 5.94.4 → 5.94.5 Changeset
@tanstack/react-query-next-experimental 5.94.4 → 5.94.5 Changeset
@tanstack/react-query-persist-client 5.94.4 → 5.94.5 Changeset
@tanstack/solid-query 5.94.4 → 5.94.5 Changeset
@tanstack/solid-query-devtools 5.94.4 → 5.94.5 Changeset
@tanstack/solid-query-persist-client 5.94.4 → 5.94.5 Changeset
@tanstack/svelte-query 6.1.6 → 6.1.7 Changeset
@tanstack/svelte-query-devtools 6.1.6 → 6.1.7 Changeset
@tanstack/svelte-query-persist-client 6.1.6 → 6.1.7 Changeset
@tanstack/vue-query 5.94.4 → 5.94.5 Changeset
@tanstack/vue-query-devtools 6.1.6 → 6.1.7 Changeset

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 21, 2026

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10312

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10312

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10312

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10312

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10312

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10312

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10312

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10312

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10312

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10312

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10312

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10312

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10312

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10312

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10312

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10312

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10312

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10312

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10312

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10312

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10312

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10312

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10312

commit: b03aaed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2026

size-limit report 📦

Path Size
react full 11.98 KB (0%)
react minimal 9.01 KB (0%)

@manudeli manudeli force-pushed the ci/build-before-publish branch from cc6c82b to 78c982a Compare March 21, 2026 15:45
…ages and fix build directory exclusion issue
@manudeli manudeli marked this pull request as ready for review March 21, 2026 15:48
@manudeli manudeli merged commit 4b6536d into main Mar 21, 2026
7 of 8 checks passed
@manudeli manudeli deleted the ci/build-before-publish branch March 21, 2026 15:50
@github-actions github-actions bot mentioned this pull request Mar 21, 2026
@manudeli manudeli linked an issue Mar 21, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build is broken 5.94.4

1 participant