Skip to content

refactor(solid-query): solid 2 reactivity compliance#10316

Open
2wheeh wants to merge 3 commits intoTanStack:solid-query-v6-prefrom
2wheeh:refactor/v2-teaks
Open

refactor(solid-query): solid 2 reactivity compliance#10316
2wheeh wants to merge 3 commits intoTanStack:solid-query-v6-prefrom
2wheeh:refactor/v2-teaks

Conversation

@2wheeh
Copy link
Contributor

@2wheeh 2wheeh commented Mar 22, 2026

🎯 Changes

From RFC: Reactivity, batching, and effects,

  • 2.0 introduces strict top-level access - explicit untrack is necessary for the top-level reactive reads in component body.
  • No writes under owned scope - signals that sync external state (e.g., query cache subscriptions) use { pureWrite: true } to opt out of the dev warning, as these are one-way writes from external callbacks, not reactive feedback loops.
  • And warning for no destructuring reactive proxies: destructuring a store proxy (const { status } = useQuery(...)) evaluates the property immediately, losing reactivity. Accessing via state.status preserves tracking.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 22, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: acaf8209-4866-4276-a103-807b40e0f89f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes.

Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.

@nx-cloud
Copy link

nx-cloud bot commented Mar 22, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 2641790

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 43s View ↗
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 55s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-22 16:36:19 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 22, 2026

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10316

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10316

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10316

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10316

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10316

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10316

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10316

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10316

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10316

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10316

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10316

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10316

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10316

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10316

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10316

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10316

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10316

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10316

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10316

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10316

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10316

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10316

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10316

commit: 2641790

@2wheeh 2wheeh marked this pull request as ready for review March 22, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: solid-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@2wheeh