Skip to content

fix(angular-table): handle null and number values with flex-render#5550

Merged
KevinVandy merged 3 commits intoTanStack:mainfrom
riccardoperra:fix/angular-flex-render-null
May 13, 2024
Merged

fix(angular-table): handle null and number values with flex-render#5550
KevinVandy merged 3 commits intoTanStack:mainfrom
riccardoperra:fix/angular-flex-render-null

Conversation

@riccardoperra
Copy link
Collaborator

@riccardoperra riccardoperra commented May 13, 2024

@KevinVandy grouping example was broken due to flexRenderDirective not handling null content (e.g. when a cell is grouped)

Screenshot 2024-05-13 alle 08 47 41

Here a screenshot of the grouping example after the fix

@nx-cloud
Copy link

nx-cloud bot commented May 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2b61063. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@jrgokavalsa
Copy link
Contributor

@riccardoperra, I've observed an issue where the aggregatedCell function is not operating correctly in conjunction with age data. Upon debugging, I found that if aggregatedCell returns a number, no values are displayed. However, when it returns a string, it functions as expected. This behavior suggests that there might be a type-related discrepancy within the renderContent function's.

@riccardoperra
Copy link
Collaborator Author

@jrgokavalsa Thanks I've forgot it. I've added a new check in order to support both string and numbers

@riccardoperra riccardoperra changed the title fix(angular-table): handle null values with flex-render fix(angular-table): handle null and number values with flex-render May 13, 2024
@KevinVandy KevinVandy merged commit f941ea6 into TanStack:main May 13, 2024
@riccardoperra riccardoperra deleted the fix/angular-flex-render-null branch May 13, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants