Fix typo with v3 artifact downloads in migration guide#511
Merged
Conversation
eggyhead
approved these changes
Jan 31, 2024
jtamsut
approved these changes
Jan 31, 2024
|
Migrating says "The new It would be better to say: |
tdfacer
pushed a commit
to ifit/upload-artifact
that referenced
this pull request
Oct 7, 2025
…typo Fix typo with v3 artifact downloads in migration guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the migration guide, the download for the v3 was as follows:
And it was stated that it would create the following directory:
This was incorrect, since no
namewas specified, it actually made an inner directory due to the behavior outlined here in the v3 docs.Instead we must provide both the name and the path to have it match the scenario we outlined.
More context: #478 (comment)