Skip to content

Add config keys for controlling public/private template secondary storage replica counts#12877

Draft
Damans227 wants to merge 3 commits intoapache:mainfrom
Damans227:feature/FR284-template-secstorage-copy-control
Draft

Add config keys for controlling public/private template secondary storage replica counts#12877
Damans227 wants to merge 3 commits intoapache:mainfrom
Damans227:feature/FR284-template-secstorage-copy-control

Conversation

@Damans227
Copy link
Collaborator

Description

Adds two new operator-level configuration keys to control the number of secondary storage copies made for public and private templates, decoupling replica count from template visibility.

  • public.template.secstorage.copy (default: 0 = all stores, preserving existing behavior)
  • private.template.secstorage.copy (default: 1, preserving existing behavior)

Types of changes

  • Breaking change
  • New feature
  • Bug fix
  • Enhancement
  • Cleanup
  • Build/CI
  • Test

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

How Has This Been Tested?

@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.02%. Comparing base (b744824) to head (0708236).

Files with missing lines Patch % Lines
.../com/cloud/template/HypervisorTemplateAdapter.java 20.00% 7 Missing and 1 partial ⚠️
...n/java/com/cloud/template/TemplateAdapterBase.java 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #12877   +/-   ##
=========================================
  Coverage     18.02%   18.02%           
- Complexity    16450    16452    +2     
=========================================
  Files          5968     5968           
  Lines        537086   537093    +7     
  Branches      65961    65964    +3     
=========================================
+ Hits          96819    96824    +5     
- Misses       429347   429348    +1     
- Partials      10920    10921    +1     
Flag Coverage Δ
uitests 3.53% <ø> (ø)
unittests 19.19% <40.90%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Damans227
Copy link
Collaborator Author

@blueorangutan package

@blueorangutan
Copy link

@Damans227 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants