Conversation
Why: schema validation tests and custom schema hosts should work without the verifier rewriting non-CommandLayer URLs to HTTPS. Contract impact: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/verifyflow was rewriting/fixing schema URLs too aggressively which broke local or custom schema hosts and made schema tests fragile.checks.schema_validis exercised without relying on external network schemas.Description
normalizeSchemaFetchUrlinserver.mjsto only rewrite CommandLayer hostnames to the canonicalhttps://www.commandlayer.orgwhile preserving other custom/local schema hosts and their scheme. (server.mjs)startSchemaHost()test helper that serves a localdescribereceipt schema and a new testschema validation fails on malformed receiptthat verifies a valid receipt passes schema validation and that removingresultcauseschecks.schema_validto becomefalse. (runtime/tests/runtime-signing.test.mjs)Testing
npm run checkwhich succeeded (Node syntax check ofserver.mjs).node --test runtime/tests/runtime-signing.test.mjswhich passed including the new regression test.npm run test:unitwhich ran all unit tests and passed (all tests green).Codex Task