Open
Conversation
Why: keep the signing chain test deterministic while schema validator startup can briefly return 202 in CI. Contract impact: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/verify?schema=1request too early and did not handle a schema validator cold start, causing flakyAbortErrorfailures in CI.Description
AbortControllertimeout for the chain verify helper from5000ms to10000ms inruntime/tests/runtime-signing.test.mjsto avoid premature aborts./verify?schema=1fetch with a bounded retry helper that logs the response status before parsing JSON, and on202logsvalidator warming, waits1200ms, and retries once.Testing
node --test runtime/tests/runtime-signing.test.mjsand the suite passed locally.AbortErroror flaky failures.Codex Task