[runtime] Short-circuit cached-only /verify schema checks early#37
Open
[runtime] Short-circuit cached-only /verify schema checks early#37
Conversation
Why: cold schema compiles were delaying /verify responses long enough to trigger client aborts instead of returning the documented 202 warmup response. Contract impact: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
POST /verify?schema=1long enough to cause client aborts instead of returning the documented fast202warmup response.Description
verband add an early cached-only guard inPOST /verify(inserver.mjs) so that whenwantSchema && VERIFY_SCHEMA_CACHED_ONLY && !hasValidatorCached(verb)the endpoint immediately enqueues warmup work and returns202withvalidator_not_warmed_yetbefore any schema fetch or AJV compilation happens.reason: "validator_not_warmed_yet"to the warmup response for the chain test retry path.Testing
npm run checkand the syntax check passed.node --test runtime/tests/runtime-signing.test.mjsand all tests passed.npm test(unit + smoke) and all tests passed.Codex Task