Open
Conversation
Why: CI needs the chain test to tolerate validator warmup without aborting after a single short retry. Contract impact: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
/verify?schema=1request helperAbortControllertimeout from5000ms to10000ms by updatingverifyReceiptWithTimeoutinruntime/tests/runtime-signing.test.mjs.console.logmessages like[chain] before verify request attempt Nand[chain] after verify response attempt N, and stops early if a200response is observed.202is returned the loop logs the warmup response and waits for theretry_after_msvalue if present, otherwise falls back to1200ms before retrying.clean/summarize/classifyand kept the final schema/hash/signature assertions unchanged, while improving failure messages to include the last status/body and any abort details.Testing
node --test runtime/tests/runtime-signing.test.mjsand the suite passed (all subtests succeeded).Codex Task