[runtime] tighten full-chain schema warmup retry test#43
Open
[runtime] tighten full-chain schema warmup retry test#43
Conversation
Why: CI needs the full-chain schema verification test to fail over to builtin schemas quickly enough for the existing verify retry to succeed. Contract impact: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
runtime/tests/runtime-signing.test.mjstest env to keepVERIFY_SCHEMA_CACHED_ONLY: "1",VERIFY_MAX_MS: "12000", setSCHEMA_FETCH_TIMEOUT_MS: "50", and keepSCHEMA_VALIDATE_BUDGET_MS: "3000"so schema fetch falls back quickly.retry_after_msfrom the202response with a1200msfallback./verify?schema=1returns200,checks.schema_valid,checks.signature_valid, andchecks.hash_matchesmust betrue.Testing
node --test runtime/tests/runtime-signing.test.mjsand all tests passed locally.Codex Task