[runtime] prefer builtin schemas during validator warmup#44
Merged
Conversation
Why: cached-only /verify warmup should avoid CI flakiness from remote schema fetches when builtin schemas already exist. Contract impact: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/verifywarmup could still hit the network before falling back to builtins, causing CI flakiness when builtin schemas are available./verifycontract.Description
optionssupport tofetchJsonWithTimeout(url, timeoutMs, options = {})and implementpreferBuiltin: truewhich normalizes the URL then usesgetBuiltinSchema()first and caches/returns it if present.makeAjv(options = {})andgetValidatorForVerb(verb, options = {}), usingfetchJsonWithTimeout(..., options)for shared refs and main schema loads.getValidatorForVerb(verb, { preferBuiltin: true })so cached-only warmup compiles validators using builtin schemas before any network fetch.validatorCacheandinflightValidator, and leave default validation paths unchanged whenpreferBuiltinis omitted.Testing
node --test runtime/tests/runtime-signing.test.mjs; all tests passed (subtests covering the full verify warmup chain succeeded).npm test(unit tests + smoke); all tests and smoke checks passed.Codex Task