Conversation
…n schema verification test resilient to cached-only validator warmup while routing verify warmup through the shared helper.\nContract impact: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/verifypublic contract while making failures clearer and deterministic.Description
runtime/tests/runtime-signing.test.mjsto replace fragile single-retry logic with a bounded 3-attempt polling loop that treats202+validator_not_warmed_yetas an expected warmup state and respectsretry_after_mswith a1000msfallback.AbortControllertimeout for/verifycalls in the test to10000msto avoid spurious aborts during warmup.verifyJson.checks.signature_valid === true,hash_matches === true, andschema_valid === true) and fail clearly if warmup never completes or an unexpected response is returned.warmQueue.add(verb)/startWarmWorker()calls in the/verifycached-only path with the canonicalwarmValidatorForVerb(verb)helper while preserving the202status, response body shape,schema_errorspayload, andretry_after_msbehavior.Testing
node --test runtime/tests/runtime-signing.test.mjsand the test suite completed successfully with the full-chain test passing./verifycontract remain unchanged.Codex Task