Draft
Conversation
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
spoenemann
reviewed
Mar 16, 2026
Contributor
spoenemann
left a comment
There was a problem hiding this comment.
Looks good so far! How can you connect your custom editor with this API?
| @@ -0,0 +1,189 @@ | |||
| // ****************************************************************************** | |||
| // Copyright 2024 TypeFox GmbH | |||
Contributor
There was a problem hiding this comment.
Suggested change
| // Copyright 2024 TypeFox GmbH | |
| // Copyright 2026 TypeFox GmbH |
| // ****************************************************************************** | ||
|
|
||
| import * as vscode from 'vscode'; | ||
| import { CollaborationInstance, PendingUser, PeerWithColor } from './collaboration-instance.js'; |
Contributor
There was a problem hiding this comment.
Shall we move the types that are made part of the API to this file (PendingUser, PeerWithColor), so we avoid breaking the API accidentally?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an api to the vscode extension allowing other extensions to leverage the oct session to sync for example their own custom editors