Fix dev server rejecting non-localhost hosts when using FX_PROFILER_HOST#5889
Fix dev server rejecting non-localhost hosts when using FX_PROFILER_HOST#5889ojuschugh1 wants to merge 3 commits intofirefox-devtools:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5889 +/- ##
=======================================
Coverage 85.42% 85.42%
=======================================
Files 321 321
Lines 32073 32073
Branches 8821 8823 +2
=======================================
Hits 27398 27398
Misses 4244 4244
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mstange
left a comment
There was a problem hiding this comment.
Thanks! Some small comments but overall looks good.
5cb9f6e to
3128e0b
Compare
|
Hey @ojuschugh1, Thanks a lot for the PR! It looks overall good, however, going thru the "Steps to reproduce" of the original issue still leads to the same error for me. Could you please have another look? |
|
Hey @fatadel, good catch - the original fix only handled the proxy's own host check but missed that esbuild itself started validating the I've pushed a fix that rewrites the |
This PR fixes #5865