test(langchain): Consolidate span origin assertion#5723
test(langchain): Consolidate span origin assertion#5723alexander-alderman-webb wants to merge 5 commits intowebb/langchain/consolidate-tool-testfrom
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Anthropic
Other
Documentation 📚
Internal Changes 🔧Langchain
Other
Other
🤖 This preview updates automatically when you update the PR. |
Codecov Results 📊✅ 32 passed | Total: 32 | Pass Rate: 100% | Execution Time: 255ms 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 15566 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 21.30% 24.50% +3.2%
==========================================
Files 189 189 —
Lines 20616 20616 —
Branches 6738 6738 —
==========================================
+ Hits 4392 5050 +658
- Misses 16224 15566 -658
- Partials 342 425 +83Generated by Codecov Action |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Consolidation drops origin check for invoke_agent span
- I restored the missing coverage by asserting the
gen_ai.invoke_agentspan origin isauto.ai.langchainin the consolidated LangChain agent test.
- I restored the missing coverage by asserting the
Or push these changes by commenting:
@cursor push 05bb2596cf
Preview (05bb2596cf)
diff --git a/tests/integrations/langchain/test_langchain.py b/tests/integrations/langchain/test_langchain.py
--- a/tests/integrations/langchain/test_langchain.py
+++ b/tests/integrations/langchain/test_langchain.py
@@ -217,12 +217,14 @@
assert tx["contexts"]["trace"]["origin"] == "manual"
chat_spans = list(x for x in tx["spans"] if x["op"] == "gen_ai.chat")
+ invoke_agent_span = next(x for x in tx["spans"] if x["op"] == "gen_ai.invoke_agent")
tool_exec_span = next(x for x in tx["spans"] if x["op"] == "gen_ai.execute_tool")
assert len(chat_spans) == 2
assert chat_spans[0]["origin"] == "auto.ai.langchain"
assert chat_spans[1]["origin"] == "auto.ai.langchain"
+ assert invoke_agent_span["origin"] == "auto.ai.langchain"
assert tool_exec_span["origin"] == "auto.ai.langchain"
# We can't guarantee anything about the "shape" of the langchain execution graphThis Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.


Description
Check span origin in
test_langchain_agent.Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)