test(langchain): Add basic agent test with Responses call#5726
Open
alexander-alderman-webb wants to merge 10 commits intowebb/langchain/remove-mocksfrom
Open
test(langchain): Add basic agent test with Responses call#5726alexander-alderman-webb wants to merge 10 commits intowebb/langchain/remove-mocksfrom
alexander-alderman-webb wants to merge 10 commits intowebb/langchain/remove-mocksfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Anthropic
Other
Documentation 📚
Internal Changes 🔧Langchain
Other
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 14 passed | Total: 14 | Pass Rate: 100% | Execution Time: 4.00s All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 15535 uncovered lines. Generated by Codecov Action |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Mutable default argument shared across function calls
- Replaced the mutable
{}default withNoneand create a fresh dict inside the fixture helper to avoid cross-call state sharing.
- Replaced the mutable
Or push these changes by commenting:
@cursor push 8a8c5fff76
Preview (8a8c5fff76)
diff --git a/tests/conftest.py b/tests/conftest.py
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -1039,7 +1039,10 @@
@pytest.fixture
def get_model_response():
- def inner(response_content, serialize_pydantic=False, request_headers={}):
+ def inner(response_content, serialize_pydantic=False, request_headers=None):
+ if request_headers is None:
+ request_headers = {}
+
model_request = HttpxRequest(
"POST",
"/responses",This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Add a test that uses
langchainfunctionality introduced in v1.0 of the library.Re-use sample Responses API response from
openai-agentstest.Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)