C++: Use FlowSource in cpp/path-injection#11638
Merged
MathiasVP merged 1 commit intogithub:mainfrom Dec 12, 2022
Merged
Conversation
a9577a3 to
60de109
Compare
60de109 to
beb66d0
Compare
MathiasVP
approved these changes
Dec 12, 2022
Contributor
MathiasVP
left a comment
There was a problem hiding this comment.
This looks great 🎉! I don't think the small performance change is a concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #11435 now we have all relevant flow sources.
DCA looks fractionally slower. I'm not sure whether that's a concern.
MRVA with 1000 projects shows more
argvrelated results (no results have disappeared). There's a large increase onmicrosoft/BlingFire(441 new results) anddanmar/cppcheck(26 new results). There are 17 other projects with at most 6 new results.