C++: Add expressions with type data to cpp/extraction-information#21544
Draft
paldepind wants to merge 1 commit intogithub:mainfrom
Draft
C++: Add expressions with type data to cpp/extraction-information#21544paldepind wants to merge 1 commit intogithub:mainfrom
cpp/extraction-information#21544paldepind wants to merge 1 commit intogithub:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #21512. Extends the query to also include data for expressions in the source with types. Like before the QL is more or less copy pasted from the similar queries for Rust/Java/C#.
Here's a comparison table for
nmapsimilar to the one in the previous PR. The first row is the existing data, and the three below are fromcpp/telemetry/extraction-information.Again, the new numbers show more clearly the actual changes from BMN and dependency installation. Though at least for this project the call target data seemed more revealing. Two observations:
Perhaps others have some additional insight, but to me it seems that the resolved calls metric is more significant.