Skip to content

feat: implement in Japanese#5

Closed
r1cA18 wants to merge 1 commit intogithub:mainfrom
r1cA18:feature/implement-in-japanese
Closed

feat: implement in Japanese#5
r1cA18 wants to merge 1 commit intogithub:mainfrom
r1cA18:feature/implement-in-japanese

Conversation

@r1cA18
Copy link

@r1cA18 r1cA18 commented Sep 3, 2025

This pull request introduces comprehensive Japanese localization for the specify_cli tool, translating all user-facing messages, help texts, and command-line prompts into Japanese. Additionally, it adds a local settings file to allow the mcp__serena__list_dir permission. The most important changes are grouped below:

Japanese Localization of CLI Tool:

Configuration/Permissions:

  • Added .claude/settings.local.json to allow the mcp__serena__list_dir permission, enabling directory listing for the relevant tool.

These changes provide full Japanese language support for the CLI and adjust tool permissions for local development.

Copilot AI review requested due to automatic review settings September 3, 2025 04:28
@r1cA18 r1cA18 requested a review from localden as a code owner September 3, 2025 04:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements comprehensive Japanese localization for the Specify CLI tool, translating all user-facing text from English to Japanese. Additionally, it adds a local configuration file to enable specific MCP permissions. The changes provide full Japanese language support for CLI users while maintaining functionality.

  • Complete Japanese translation of all CLI messages, help text, and command descriptions
  • Translation of template files for specifications, plans, and task generation
  • Addition of local settings file for MCP permission configuration

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/specify_cli/init.py Complete Japanese localization of CLI interface, help text, error messages, and user prompts
templates/tasks-template.md Full Japanese translation of task template structure and documentation
templates/spec-template.md Japanese translation of specification template format and guidelines
templates/plan-template.md Complete Japanese localization of implementation plan template
templates/commands/tasks.md Japanese translation of tasks command documentation
templates/commands/specify.md Japanese translation of specify command documentation
templates/commands/plan.md Japanese translation of plan command documentation
templates/agent-file-template.md Japanese translation of agent file template structure
.claude/settings.local.json New configuration file enabling mcp__serena__list_dir permission

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +13 to 22
Specify CLI - Specifyプロジェクトのセットアップツール

Usage:
uvx specify-cli.py init <project-name>
使用方法:
uvx specify-cli.py init <プロジェクト名>
uvx specify-cli.py init --here

Or install globally:
またはグローバルインストール:
uv tool install --from specify-cli.py specify-cli
specify init <project-name>
specify init <プロジェクト名>
specify init --here
Copy link

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module docstring should maintain the original English documentation for technical accuracy, with Japanese translations provided separately for user-facing content. Technical documentation and API references are typically kept in English for consistency with the broader development ecosystem.

Copilot uses AI. Check for mistakes.
Comment on lines +69 to +70
"""階層的なステップをトラッキングして表示。Claude Codeのツリー出力と同様のスタイル。
アタッチされたリフレッシュコールバックによる自動更新をサポート。
Copy link

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class docstrings should remain in English as they document the internal API for developers. Japanese translations should be limited to user-facing messages and interface text.

Suggested change
"""階層的なステップをトラッキングして表示Claude Codeのツリー出力と同様のスタイル
アタッチされたリフレッシュコールバックによる自動更新をサポート
"""Tracks and displays hierarchical steps in a tree-style format, similar to Claude Code's output.
Supports automatic UI refresh via an attached callback.

Copilot uses AI. Check for mistakes.

def check_tool(tool: str, install_hint: str) -> bool:
"""Check if a tool is installed."""
"""ツールがインストールされているか確認。"""
Copy link

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function docstrings should remain in English for API documentation consistency. Only user-facing output should be translated to Japanese.

Suggested change
"""ツールがインストールされているか確認。"""
"""Check if the tool is installed."""

Copilot uses AI. Check for mistakes.
@app.callback()
def callback(ctx: typer.Context):
"""Show banner when no subcommand is provided."""
"""サブコマンドが提供されない場合にバナーを表示。"""
Copy link

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function docstrings should remain in English for consistency with development documentation standards. Japanese should be used only for user-facing messages.

Suggested change
"""サブコマンドが提供されない場合にバナーを表示。"""
"""Show the banner when no subcommand is provided."""

Copilot uses AI. Check for mistakes.
@r1cA18 r1cA18 closed this Sep 3, 2025
@r1cA18 r1cA18 deleted the feature/implement-in-japanese branch September 3, 2025 04:32
@r1cA18
Copy link
Author

r1cA18 commented Sep 3, 2025

I meant to make a PR to the fork, but accidentally did it here. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants