perf: Make executor data uploads async internally#2529
Merged
TrevorBergeron merged 4 commits intomainfrom Mar 24, 2026
Merged
Conversation
sycai
reviewed
Mar 23, 2026
Comment on lines
+307
to
+313
| def read_data_async( | ||
| self, local_data: local_data.ManagedArrowTable, offsets_col: str | ||
| ) -> concurrent.futures.Future[bq_data.BigqueryDataSource]: | ||
| future = self._threadpool.submit( | ||
| self._load_data_or_write_data, local_data, offsets_col | ||
| ) | ||
| return future |
Contributor
There was a problem hiding this comment.
Shall we write a test for this function?
Contributor
Author
There was a problem hiding this comment.
This functionality is covered by the tests in https://github.com/googleapis/python-bigquery-dataframes/blob/main/tests/system/small/test_large_local_data.py. I'm uncertain about adding more targeted tests of internal classes, since the current class/method boundaries will be subject to further change soon
Contributor
There was a problem hiding this comment.
Okay, I'm good as long as it's under some test coverage.
sycai
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕