Add warning when using CUDA random generator (#13298)#13309
Open
r266-tech wants to merge 1 commit intohuggingface:mainfrom
Open
Add warning when using CUDA random generator (#13298)#13309r266-tech wants to merge 1 commit intohuggingface:mainfrom
r266-tech wants to merge 1 commit intohuggingface:mainfrom
Conversation
Warn users that CUDA generators produce different random numbers than CPU generators with the same seed, since PyTorch uses different RNG algorithms on each device. This helps users understand why their images differ when switching generator devices. Fixes huggingface#13298
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13298
When users pass a CUDA
torch.Generatorto diffusers pipelines, they may expect the same results as with a CPU generator given the same seed. However, PyTorch uses different random number generation algorithms on CPU and CUDA, so the generated images will differ.This PR adds a warning in
randn_tensorwhen a CUDA generator is used, informing users that:Before submitting
Who can review?
@yiyixuxu @DN6 @sayakpaul