fix: shortened the test file and added README.md#7
Merged
PranshuSrivastava merged 4 commits intomainfrom Feb 27, 2024
Merged
Conversation
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Keploy.py
Outdated
| logger.error(f"Test set: {test_set} failed") | ||
| break | ||
| # If 1 minute has passed we exit. | ||
| if time.time() - startTime > 60: |
There was a problem hiding this comment.
what if I have very large number of testCases in my test-set which will definitely take more than 60s
Keploy.py
Outdated
| FAILED = 3 | ||
|
|
||
| def run(run_cmd): | ||
| global user_command_pid |
There was a problem hiding this comment.
do we really need a global variable..? we can just pass them in functions right..?
Keploy.py
Outdated
| logger = logging.getLogger('Keploy') | ||
|
|
||
| GRAPHQL_ENDPOINT = "/query" | ||
| HOST = "http://localhost:" |
Keploy.py
Outdated
| @@ -1,12 +1,14 @@ | |||
| import json | |||
| import psutil | |||
There was a problem hiding this comment.
Normally the folder structure followed by python libraries would be :
src/keploy
in this folder you can have run.py file which will have this content.
this folder may contain other files like init etc .
try to follow this convention.
| import time | ||
|
|
||
| logger = logging.getLogger('KeployCLI') | ||
| logging.basicConfig(level=logging.info) |
There was a problem hiding this comment.
I don't see any requirements.txt file, this library to run locally don't I need any dependencies?
setup.py
Outdated
| from setuptools import setup, find_packages | ||
|
|
||
| VERSION = '0.0.1' | ||
| VERSION = '2.0.0-alpha11' |
There was a problem hiding this comment.
what is this version 2.0.0-alpha11?
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue that this pull request solves
The test file used to be unnecessarily long, making it difficult for users to work with it. There was also no README present so it made tough for users to use pytest.
Brief description of what is fixed or changed
Handled majority of the functionality of the test file in the sdk itself so as to shorten the length of the test file, also added a README file according to the current changes.
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyOther information
Any other information that is important to this pull request