refspec: rename git_refspec__free to git_refspec__dispose#4709
Merged
ethomson merged 1 commit intolibgit2:masterfrom Jun 29, 2018
Merged
refspec: rename git_refspec__free to git_refspec__dispose#4709ethomson merged 1 commit intolibgit2:masterfrom
git_refspec__free to git_refspec__dispose#4709ethomson merged 1 commit intolibgit2:masterfrom
Conversation
Since commit 630a673 (refspec: add public parsing api, 2018-02-07), we now have two functions `git_refspec_free` and `git_refspec__free`. The difference is that the first one will free the structure itself, while the second one will only free the structure's contents. Use our new `dispose` naming pattern for the latter function to help avoid confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since commit 630a673 (refspec: add public parsing api, 2018-02-07), we
now have two functions
git_refspec_freeandgit_refspec__free. Thedifference is that the first one will free the structure itself, while
the second one will only free the structure's contents. Use our new
disposenaming pattern for the latter function to help avoidconfusion.