Skip to content

fix(git-node): remove duplicated code in prepare_release.js#1047

Open
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:security-not-that-special
Open

fix(git-node): remove duplicated code in prepare_release.js#1047
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:security-not-that-special

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 22, 2026

As I was working on security release, I noticed the --release-date flag was ignored. I figured, rather than trying to fix all the flags, it'd be better to remove the duplication and re-use the well tested regular release path.

Security releases preparation follow the same steps as regular releases, having duplicated steps is only cumbersome AFAICT.

Security releases preparation follow the same steps as regular releases,
having duplicated steps is only cumbersome AFAICT.
@codecov
Copy link

codecov bot commented Mar 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.93%. Comparing base (5034b4f) to head (6541519).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1047   +/-   ##
=======================================
  Coverage   80.93%   80.93%           
=======================================
  Files          39       39           
  Lines        4841     4841           
=======================================
  Hits         3918     3918           
  Misses        923      923           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant