http2: pass incoming set-cookie header as array#21360
Closed
Flarna wants to merge 1 commit intonodejs:masterfrom
Flarna:http2_set-cookie_array
Closed
http2: pass incoming set-cookie header as array#21360Flarna wants to merge 1 commit intonodejs:masterfrom Flarna:http2_set-cookie_array
Flarna wants to merge 1 commit intonodejs:masterfrom
Flarna:http2_set-cookie_array
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incoming set-cookie headers should be passed to user as array like in http module - even for single occurrence.
Besides improving compatibility between http and http2 it avoids the need to check if the type is an array or not in user code.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesRegarding doc: If this PR is accepted #21296 should be updated accordingly - or doc needs to be adapted in this PR if #21296 landed meanwhile.