Skip to content

tools: Use print() function on both Python 2 and 3#24486

Merged
refack merged 1 commit intonodejs:masterfrom
cclauss:tools-print-function
Nov 26, 2018
Merged

tools: Use print() function on both Python 2 and 3#24486
refack merged 1 commit intonodejs:masterfrom
cclauss:tools-print-function

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 19, 2018 •
edited by addaleax
Loading

A subset of #23669 to simplify the review process. @refack @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srl295 srl295 srl295 left review comments

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

+3 more reviewers

@aslushnikov aslushnikov aslushnikov left review comments

@refack refack refack approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation. python PRs and issues that require attention from people who are familiar with Python. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@cclauss @addaleax @Trott @refack @thefourtheye @srl295 @jasnell @aslushnikov @BethGriggs @nodejs-github-bot