Skip to content

chore: add #include <string> in json_utils.h#33332

Closed
zcbenz wants to merge 1 commit intonodejs:masterfrom
zcbenz:patch-1
Closed

chore: add #include <string> in json_utils.h#33332
zcbenz wants to merge 1 commit intonodejs:masterfrom
zcbenz:patch-1

Conversation

@zcbenz
Copy link
Contributor

@zcbenz zcbenz commented May 10, 2020

When precompile headers are disabled this file would cause compilation errors due to #include <string> not included.

d:\a\1\s\node\src\json_utils.h(141): error C2679: binary '<<': no operator found which takes a right-hand operand of type 'std::string' (or there is no acceptable conversion)
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants