Skip to content

src: make minor improvements to SecureBuffer#44302

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
tniessen:src-update-securebuffer
Aug 22, 2022
Merged

src: make minor improvements to SecureBuffer#44302
nodejs-github-bot merged 1 commit intonodejs:mainfrom
tniessen:src-update-securebuffer

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Aug 20, 2022

  • Remove an unnecessary static_cast<char*>().
  • Use OPENSSL_secure_zalloc() instead of OPENSSL_secure_malloc() + memset().
  • Update the comment describing the function which predates support for OpenSSL's secure heap.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes

@addaleax addaleax addaleax approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tniessen @nodejs-github-bot @panva @addaleax