Open
Conversation
Collaborator
|
Review requested:
|
This was referenced Mar 22, 2026
jasnell
reviewed
Mar 22, 2026
| auto point = ECPointPointer::New(group); | ||
| if (!point) return false; | ||
| if (!point.setFromBuffer({ptr, uncompressed_len}, group)) return false; | ||
| return EC_KEY_set_public_key(key_.get(), point.get()) == 1; |
Member
There was a problem hiding this comment.
The change looks fine but is the ncrypto repo PR opened for it? We really need to get the proper dependency update flow working there
Member
Author
There was a problem hiding this comment.
I do not share the sense of urgency but yes i've opened an ncrypto PR with the changes from this and the other PR.
themavik
reviewed
Mar 23, 2026
themavik
left a comment
There was a problem hiding this comment.
Skipping EC_KEY_check_key when cofactor is 1 via EC_POINT_oct2point is a smart fast path in ECKeyPointer::setPublicKeyRaw. nit: confirm x.encodePaddedInto/y.encodePaddedInto always fill field_len bytes for curves you care about; weird encodings short of field_len would be a footgun.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All EC JWK import supported curves go through the optimized branch but I left the old one in just in case.