Skip to content

deps: add perfetto sdk#62397

Open
legendecas wants to merge 3 commits intonodejs:mainfrom
legendecas:perfetto-sdk
Open

deps: add perfetto sdk#62397
legendecas wants to merge 3 commits intonodejs:mainfrom
legendecas:perfetto-sdk

Conversation

@legendecas
Copy link
Member

@legendecas legendecas commented Mar 22, 2026

This adds Perfetto SDK as a dependency of Node.js. Notably, this does not add the full Perfetto library as the dependency. The full perfetto library contains Perfetto data pipeline processing support. The Perfetto SDK only supports emitting tracing data.

This is part of the nodejs/diagnostics#654 discussion that V8 moves away from the legacy tracing library.

Key points:

  • The Perfetto support in Node.js would only support binary protobuf data emission.
  • The support does not emit JSON trace data (as the perfetto library uses libjsoncpp to translate protobuf data to JSON at runtime. The Perfetto library does not emit JSON directly)
  • Smaller dependency and produced library size.

This PR only adds the Perfetto SDK. The actual adoption is blocked on #61898 with patches in https://issues.chromium.org/issues/457135433.

Commit efdce9a can be fully reproduced with tools/dep_updaters/update-perfetto.sh.

Refs: nodejs/diagnostics#654
Refs: https://issues.chromium.org/issues/457135433

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Mar 22, 2026
@legendecas legendecas added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. labels Mar 22, 2026
@eagle19900203-boop

This comment was marked as spam.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants