Skip to content

cluster: guard against undefined message handlers#6902

Merged
cjihrig merged 1 commit intonodejs:masterfrom
cjihrig:6561
May 25, 2016
Merged

cluster: guard against undefined message handlers#6902
cjihrig merged 1 commit intonodejs:masterfrom
cjihrig:6561

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 20, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

cluster

Description of change

cluster's internal message handling includes a cache of callback functions. Once the message for that callback is received, it is removed from the cache. If, for any reason, the same message ID is processed twice, the callback will be missing from the cache and cluster will try to call undefined as a function. This commit guards against this scenario.

Fixes #6561

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cluster Issues and PRs related to the cluster subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants