improve: add information about SSA use to the debug logs#2914
Merged
metacosm merged 1 commit intooperator-framework:mainfrom Aug 26, 2025
Merged
improve: add information about SSA use to the debug logs#2914metacosm merged 1 commit intooperator-framework:mainfrom
metacosm merged 1 commit intooperator-framework:mainfrom
Conversation
Collaborator
xstefank
commented
Aug 26, 2025
Signed-off-by: xstefank <xstefank122@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances debug logging by adding information about Server-Side Apply (SSA) usage to help with troubleshooting and understanding resource update behavior.
- Adds SSA flag information to debug log statements in resource update operations
- Optimizes the SSA check in KubernetesDependentResource by caching the result
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ReconciliationDispatcher.java | Adds SSA usage information to the debug log when patching resources |
| KubernetesDependentResource.java | Adds SSA information to debug logs and optimizes by caching the SSA check result |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
|
|
||
| public R update(R actual, R desired, P primary, Context<P> context) { | ||
| boolean useSSA = useSSA(context); |
There was a problem hiding this comment.
The useSSA(context) method is called twice in the original code (lines 87 and 95). Caching the result in a local variable is a good optimization that eliminates the duplicate method call.
csviri
approved these changes
Aug 26, 2025
Donnerbart
pushed a commit
to Donnerbart/java-operator-sdk
that referenced
this pull request
Aug 28, 2025
…amework#2914) Signed-off-by: xstefank <xstefank122@gmail.com>
xstefank
added a commit
to xstefank/java-operator-sdk
that referenced
this pull request
Aug 28, 2025
…amework#2914) Signed-off-by: xstefank <xstefank122@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.