test: improve the tests for in_array#21087
Conversation
Girgias
left a comment
There was a problem hiding this comment.
I'd rather split this test into multiple ones because trying to verify that 200 iterations of a foreach is corret is just unreasonable.
a7dd7b0 to
c64920f
Compare
|
Is splitting reference-value data into a separate test appropriate? I added descriptions to each iteration to make the test results easier to review. |
99b25bb to
0a40431
Compare
|
Thanks for the review. I understand you now. All feedback has been addressed: the large test was split into 9 files inside |
54dcc04 to
77d99c4
Compare
Girgias
left a comment
There was a problem hiding this comment.
Thanks, sorry for taking this long I was feeling somewhat unwell recently.
|
No problem, thank you! |
Added more detailed descriptions to test iterations so it’s clear what the input is for each iteration. Additionally, I added a new test cases for an arrays containing references and enums.