Skip to content

zend_builtin_functions.c: add const qualifiers#21487

Merged
Girgias merged 2 commits intophp:masterfrom
Girgias:builtin-fns-const
Mar 23, 2026
Merged

zend_builtin_functions.c: add const qualifiers#21487
Girgias merged 2 commits intophp:masterfrom
Girgias:builtin-fns-const

Conversation

@Girgias
Copy link
Member

@Girgias Girgias commented Mar 21, 2026

No description provided.

@Girgias Girgias marked this pull request as ready for review March 21, 2026 18:48
@Girgias Girgias requested a review from TimWolla March 21, 2026 18:48
zend_class_entry *called_scope;

ZEND_PARSE_PARAMETERS_NONE();
{ ZEND_PARSE_PARAMETERS_NONE();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest leaving these on separate lines

Suggested change
{ ZEND_PARSE_PARAMETERS_NONE();
{
ZEND_PARSE_PARAMETERS_NONE();

Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for Daniel's note.

@Girgias Girgias merged commit d34c840 into php:master Mar 23, 2026
1 of 2 checks passed
@Girgias Girgias deleted the builtin-fns-const branch March 23, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants