[RFC][mbregex] Set deprecate Oniguruma(mbregex)#21490
Draft
youkidearitai wants to merge 3 commits intophp:masterfrom
Draft
[RFC][mbregex] Set deprecate Oniguruma(mbregex)#21490youkidearitai wants to merge 3 commits intophp:masterfrom
youkidearitai wants to merge 3 commits intophp:masterfrom
Conversation
alecpl
reviewed
Mar 22, 2026
ext/mbstring/mbstring.stub.php
Outdated
|
|
||
| #ifdef HAVE_MBREGEX | ||
| /** @refcount 1 */ | ||
| #[\Deprecated(since: '8.6', message: "mbregex support end PHP 9.0")] |
There was a problem hiding this comment.
Proper English would be "support ends in PHP 9.0". I don't think mentioning "mbregex" to end-user is useful.
Contributor
Author
There was a problem hiding this comment.
I see. I tried fix messages.
Contributor
Author
There was a problem hiding this comment.
However, there is mbregex module. I'm worried.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/eol-oniguruma
Deprecate Oniguruma.