ext/bcmath: Fix bc_str2num accepting strings with embedded null bytes#21492
Open
jorgsowa wants to merge 1 commit intophp:masterfrom
Open
ext/bcmath: Fix bc_str2num accepting strings with embedded null bytes#21492jorgsowa wants to merge 1 commit intophp:masterfrom
jorgsowa wants to merge 1 commit intophp:masterfrom
Conversation
Contributor
|
Is this technically a bc break? Would RFC in this case be required or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bc_str2numaccepts an explicit end boundary pointer but validated input using null-terminator checks (*ptr != '\0'). This caused strings with embedded null bytes to be silently truncated rather than rejected."100\x005"was parsed as"100"while"100a5"correctly threw a ValueError.