Fix #2989: dcc.Dropdown options order preserved during search#3680
Open
ines-om wants to merge 1 commit intoplotly:devfrom
Open
Fix #2989: dcc.Dropdown options order preserved during search#3680ines-om wants to merge 1 commit intoplotly:devfrom
ines-om wants to merge 1 commit intoplotly:devfrom
Conversation
When searching in dcc.Dropdown, results should maintain the original option order instead of being reordered by js-search. By creating a Set of search results and filtering the original options array, we preserve order while maintaining performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2989.
When searching in
dcc.Dropdown, search results should be presented in the original option order instead of being reordered byjs-search. This is achieved by creating a Set of the search results and filtering the original options array against it, preserving the intended order.Contributor Checklist
DropdownSearch.tsxto preserve user-defined order in search resultsoptionals
CHANGELOG.md