fix: precise_diff inconsistent with pendulum.DateTime subclasses (#906)#953
Open
r266-tech wants to merge 1 commit intopython-pendulum:masterfrom
Open
fix: precise_diff inconsistent with pendulum.DateTime subclasses (#906)#953r266-tech wants to merge 1 commit intopython-pendulum:masterfrom
r266-tech wants to merge 1 commit intopython-pendulum:masterfrom
Conversation
The Rust helper used for dt1 but for dt2. Since is a subclass of , returns False for it, causing dt2's time components to be left at zero. This led to incorrect interval calculations when using native objects (which get converted to in ). Fixes python-pendulum#906
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
pendulum.interval()is called with nativedatetime.datetimeobjects, the resulting interval produces incorrect values forin_words(),hours,minutes, etc. This is becauseInterval.__init__converts native datetimes topendulum.DateTime, but the underlying Rustprecise_difffunction handles them inconsistently.Example:
Root Cause
In
rust/src/python/helpers.rs, theprecise_difffunction uses inconsistent type checks:is_datetime: PyDateTime::is_type_of(dt1)— returnsTrueforpendulum.DateTime(subclass)is_datetime: PyDateTime::is_exact_type_of(dt2)— returnsFalseforpendulum.DateTimeWhen
dt2.is_datetimeisFalse, its hour/minute/second components are left at 0, producing an incorrect diff.Fix
Changed line 187 from
is_exact_type_oftois_type_ofto match line 174.Testing
test_native_datetime_interval_consistencythat verifies native and pendulum datetime inputs produce identical resultsFixes #906