Validate gh-issue is int before checking range, and that gh-issue or bpo exists#35
Merged
hugovk merged 6 commits intopython:mainfrom Nov 10, 2024
Merged
Validate gh-issue is int before checking range, and that gh-issue or bpo exists#35hugovk merged 6 commits intopython:mainfrom
hugovk merged 6 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34.
For the first part:
We were checking gh-issue is in the correct range (32426 or higher) before checking it's an int, and so getting a general
ValueError: invalid literal for int() with base 10: ''instead of a better Blurb one:Invalid GitHub issue number! ('').For the second part:
Ensure one of
gh-issueorbpoexists in the metadata.Also add more unit tests for
Blurb.parse().