gh-101000: Add os.path.splitroot()#101002
Merged
AlexWaygood merged 31 commits intopython:mainfrom Jan 27, 2023
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
os.path.splitroot(). See #101000 for motivation.In
ntpath, the implementation derives fromsplitdrive(). Thesplitdrive()function now callssplitroot(), and returnsdrive, root + tail. Other functions now callsplitroot()rather thansplitdrive(). In most cases this replaces their own parsing of path roots. It also avoids adding a stack frame.In
posixpath, thenormpath()function now callssplitroot()rather than parsing path roots itself.In
pathlib, path constructors now callsplitroot()rather than using a slow OS-agnostic implementation. Performance:Future work:
nt._path_splitroot()