gh-93627: Align Python implementation of pickle with C implementation of pickle#103035
Merged
serhiy-storchaka merged 45 commits intopython:mainfrom Sep 10, 2023
Merged
gh-93627: Align Python implementation of pickle with C implementation of pickle#103035serhiy-storchaka merged 45 commits intopython:mainfrom
serhiy-storchaka merged 45 commits intopython:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we align the python and C implementation of
picklemodule. In this PR we have chosen to modify all implementations to follow the c implementation of pickle conventions: if a method like__reduce_ex_or__reduce__is set toNone, aTypeErroris raised.Since the behaviour of the python and c implemenations is not equal, any PR aliging the two cannot be fully backwards compatible. The impact seems limited:
__reduce_ex__attribute of a class toNone, instead of creating a method)Notes:
copymodule have been removed from the PR.