Skip to content

[3.7] bpo-35045: Accept TLSv1 default in min max test (GH-11510)#11611

Merged
miss-islington merged 1 commit intopython:3.7from
miss-islington:backport-34de2d3-3.7
Jan 18, 2019
Merged

[3.7] bpo-35045: Accept TLSv1 default in min max test (GH-11510)#11611
miss-islington merged 1 commit intopython:3.7from
miss-islington:backport-34de2d3-3.7

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 18, 2019 •
edited by bedevere-bot
Loading

Make ssl tests less strict and also accept TLSv1 as system default. The
changes unbreaks test_min_max_version on Fedora 29.

Signed-off-by: Christian Heimes christian@python.org
(cherry picked from commit 34de2d3)

Co-authored-by: Christian Heimes christian@python.org

https://bugs.python.org/issue35045

@tiran @miss-islington
bpo-35045: Accept TLSv1 default in min max test (pythonGH-11510)
f4e5a88 
Make ssl tests less strict and also accept TLSv1 as system default. The
changes unbreaks test_min_max_version on Fedora 29.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 34de2d3)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot mentioned this pull request Jan 18, 2019
Merged
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 18, 2019
vstinner
vstinner approved these changes Jan 18, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 18, 2019

@tiran and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 6ca7183 into python:3.7 Jan 18, 2019
@miss-islington miss-islington deleted the backport-34de2d3-3.7 branch January 18, 2019 15:29
@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 18, 2019

@tiran and @vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot @tiran