gh-91887: Store strong references to pending tasks#121264
Open
alexhartl wants to merge 5 commits intopython:mainfrom
Open
gh-91887: Store strong references to pending tasks#121264alexhartl wants to merge 5 commits intopython:mainfrom
alexhartl wants to merge 5 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
_pending_tasksset toBaseEventLoop. OnTaskcreation, a (strong) reference to the task is added to this set in_register_task. When a task completes, the respective reference is removed from_pending_tasksin_unregister_task. See the discussion at #91887.