gh-126018: Avoid aborting due to unnecessary assert in sys.audit#126020
Merged
JelleZijlstra merged 7 commits intopython:mainfrom Oct 27, 2024
Merged
gh-126018: Avoid aborting due to unnecessary assert in sys.audit#126020JelleZijlstra merged 7 commits intopython:mainfrom
sys.audit#126020JelleZijlstra merged 7 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes an assert in
sysmodule.cthat caused the interpreter to abort whensys.auditreceived a non-string as first argument.Without this assert, the code that runs the hooks will raise an exception instead.
sys.audit(0)aborts due to an assertion in debug build #126018