gh-135552: Clear weakrefs to types in GC after garbage finalization not before#135728
Closed
sergey-miryanov wants to merge 12 commits intopython:mainfrom
Closed
gh-135552: Clear weakrefs to types in GC after garbage finalization not before#135728sergey-miryanov wants to merge 12 commits intopython:mainfrom
sergey-miryanov wants to merge 12 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to find the root cause of the linked issue, I observed that the type cache was holding an obsolete reference. Because the type cache holds borrowed references, this leads to a use-after-free error.
I'm resetting the cache in this PR. But I suspect that this may affect overall performance.