Skip to content

gh-145719: Add .efi file detection in mimetypes#145720

Merged
hugovk merged 8 commits intopython:mainfrom
clin1234:patch-6
Mar 23, 2026
Merged

gh-145719: Add .efi file detection in mimetypes#145720
hugovk merged 8 commits intopython:mainfrom
clin1234:patch-6

Conversation

@clin1234
Copy link
Contributor

@clin1234 clin1234 commented Mar 10, 2026

@clin1234
Copy link
Contributor Author

@aisk, mind reviewing my PR?

@clin1234
Copy link
Contributor Author

@hugovk, mind reviewing this PR as well?

@aisk
Copy link
Member

aisk commented Mar 11, 2026

Hi, please don't be too pushy and mention people to review the PR immediately. Python is an open source project and most maintainers are using their spare time to do the work.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming IANA reg: https://www.iana.org/assignments/media-types/application/efi

@clin1234 Please could you follow the same pattern as #145718?

  • No need for test if it's repeating the MIME type. Useful tests are for when we're testing priority of multiple extensions, or some new code path/logic.
  • Add to What's New.

Thanks.

clin1234 and others added 2 commits March 12, 2026 13:57
…kJRoK.rst

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@clin1234 clin1234 requested a review from AA-Turner as a code owner March 12, 2026 18:00
@hugovk hugovk merged commit 821581a into python:main Mar 23, 2026
47 checks passed
@clin1234 clin1234 deleted the patch-6 branch March 23, 2026 20:22
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Mar 24, 2026
…on into fix-pythongh-138577

* 'fix-pythongh-138577' of github.com:CuriousLearner/cpython:
  pythongh-146202: Create tmp_dir in regrtest worker (python#146347)
  pythongh-144319: obtain SeLockMemoryPrivilege on Windows (python#144928)
  pythongh-146199: Fix error handling in `code_richcompare` when `PyObject_RichCompareBool` fails (python#146200)
  pythongh-146197: Include a bit more information in sys._emscripten_info.runtime (python#146346)
  pythongh-135871: Reload lock internal state while spinning in `PyMutex_LockTimed` (pythongh-146064)
  pythongh-145719: Add `.efi` file detection in `mimetypes` (python#145720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants