gh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expression failure#146246
Open
Wulian233 wants to merge 5 commits intopython:mainfrom
Open
gh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expression failure#146246Wulian233 wants to merge 5 commits intopython:mainfrom
SET_ITEM macro leaks dict on expression failure#146246Wulian233 wants to merge 5 commits intopython:mainfrom
Conversation
… evaluation fails
Contributor
Author
|
@serhiy-storchaka Could you please help review this PR? Thank you very much! |
| @@ -0,0 +1,2 @@ | |||
| Fix memory leak in ``SET_ITEM`` macro in ``initconfig.c`` when expression | |||
Member
There was a problem hiding this comment.
SET_ITEM and initconfig.c are implementation details not visibly to the user.
Since it is difficult to reproduce the leak (it will likely happens when the Python interpreter fails to launch, and all program memory will be freed in any case), I think that a NEWS entry is not required for this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SET_ITEMmacro leaks dict on expression failure #146244